Added support for fortnight and century #987

Mr-Sunglasses · 2021-09-27T18:30:54Z

Add support for other words ("decade", "fortnight", "century"...) #725

Gallaecio · 2021-09-28T06:33:04Z

You seem to have accidentally deleted a file.

Mr-Sunglasses · 2021-09-28T07:10:25Z

ohk I'm fixing them

Mr-Sunglasses · 2021-09-28T07:23:04Z

@Gallaecio fixes the files , Now it seems like everything is Ok

codecov · 2021-09-28T13:02:49Z

Codecov Report

Merging #987 (b461617) into master (0ed979e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head b461617 differs from pull request most recent head da174a8. Consider uploading reports for the commit da174a8 to get more accurate results

@@            Coverage Diff             @@
##           master     #987      +/-   ##
==========================================
- Coverage   98.29%   98.29%   -0.01%     
==========================================
  Files         234      234              
  Lines        2702     2700       -2     
==========================================
- Hits         2656     2654       -2     
  Misses         46       46

Impacted Files	Coverage Δ
dateparser/data/date_translation_data/en.py	`100.00% <ø> (ø)`
dateparser/data/date_translation_data/hi.py	`100.00% <ø> (ø)`
dateparser/languages/dictionary.py	`100.00% <ø> (ø)`
dateparser/freshness_date_parser.py	`99.07% <100.00%> (+0.05%)`	⬆️
dateparser/date_parser.py	`93.75% <0.00%> (-0.19%)`	⬇️
dateparser/date.py	`99.24% <0.00%> (-0.02%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed979e...da174a8. Read the comment docs.

Gallaecio

I see tests only use “century”, in singular. I think it would be good to also cover its plural, both the grammatically correct “centuries” and the supported typo “centurys”.

Mr-Sunglasses · 2021-09-28T13:49:04Z

@Gallaecio ok I'll add them on tests , Thanks for your support and guidance

Gallaecio

Thank you!

noviluni · 2021-10-04T07:41:03Z

dateparser_data/supplementary_language_data/date_translation_data/en.yaml

+    in \1 century:
+        - in (\d+) century?
+    \1 century ago:
+        - (\d+) century? ago
+    in \1 fortnight:
+        - in (\d+) fortnight?
+    \1 fortnight ago:
+        - (\d+) fortnight? ago


This is not correct. The ? indicates an optional letter.

Doing this it will accepts "in 1 century" but also "in 1 centur". You need to add an s before the ?.
Also, you should need to add support for centuries here.

You can check if both thigns work with this

dateparser.parse("in 3 centurys")

and:

dateparser.parse("in 3 centuries")

Now both are failing.

@noviluni sure fixing the bug.

@noviluni The tests are failing for centuries , even I added them on en.yaml.

Gallaecio · 2021-10-05T05:55:22Z

dateparser/data/date_translation_data/en.py

@@ -280,10 +280,10 @@
            "(\\d+) decades? ago"
        ],
        "in \\1 century": [
-            "in (\\d+) century?"
+            "in (\\d+) centurys?"


I think it needs to be something like centur(?:ys?|ies)

@Gallaecio Just tried this , Tests are failing when I used it.

Mr-Sunglasses · 2021-12-05T19:12:45Z

@Gallaecio - I have fixed all the changes that you were request 😊

gutsytechster · 2022-06-16T14:02:08Z

tests/test_freshness_date_parser.py

+        param('last fortnight', ago={'days': 14}, period='day'),
+        param('14 fortnight', ago={'days': 196}, period='day'),
+        param('a fortnight ago', ago={'days': 14}, period='day'),
+        param('last fortnight', ago={'days': 14}, period='day'),


I believe this is repeated and the same as in line 61.

@gutsytechster Done this change, Please Look into it 😊.

gutsytechster · 2022-06-16T14:02:39Z

tests/test_freshness_date_parser.py

+        param('last fortnight', ago={'days': 14}, period='day'),
+        param('14 fortnight', ago={'days': 196}, period='day'),
+        param('a fortnight ago', ago={'days': 14}, period='day'),
+        param('last fortnight', ago={'days': 14}, period='day'),


Same as above. It is repeated as well.

@gutsytechster Done this change, Please Look into it 😊.

gutsytechster · 2022-06-16T14:05:52Z

tests/test_freshness_date_parser.py

@@ -841,6 +871,7 @@ def test_relative_past_dates(self, date_string, ago, period):
        param('1 वर्ष, 8 महीने, 2 सप्ताह', ago={'years': 1, 'months': 8, 'weeks': 2}, period='week'),
        param('1 वर्ष 7 महीने', ago={'years': 1, 'months': 7}, period='month'),
        param('आज', ago={'days': 0}, period='day'),
+        param('1 दशक पहले', ago={'years': 10}, period='year'),


Can we add a few more test cases for the Hindi version here? For e.g.

1 दशक पूर्व

दो दशक पहले

10 दशकों पहले

@gutsytechster Done this change, Please Look into it 😊.

gutsytechster · 2022-06-16T14:10:27Z

tests/test_freshness_date_parser.py

@@ -1160,6 +1199,7 @@ def test_normalized_relative_dates(self, date_string, ago, period):
        param('17 सेकंड बाद', in_future={'seconds': 17}, period='day'),
        param('1 वर्ष, 5 महीने, 1 सप्ताह में',
              in_future={'years': 1, 'months': 5, 'weeks': 1}, period='week'),
+        param('1 दशक में', in_future={'years': 10}, period='year'),


Could we also add a few more test cases for the Hindi version here? For e.g.

पांच दशक बाद

दश दशक पश्चात

9 दशकों मे

@gutsytechster Done this change, Please Look into it 😊.

gutsytechster · 2022-06-16T14:12:47Z

tests/test_freshness_date_parser.py

@@ -1066,6 +1097,14 @@ def test_normalized_relative_dates(self, date_string, ago, period):

    @parameterized.expand([
        # English dates
+        param('in a fortnight', in_future={'days': 14}, period='day'),
+        param('next fortnight', in_future={'days': 14}, period='day'),


I am not sure, but do we support coming fortnight?

@gutsytechster Done this change, Please Look into it 😊.

gutsytechster · 2022-06-16T14:13:58Z

tests/test_freshness_date_parser.py

+        param('1 दशक', ago={'years': 10}, period='year'),
+        param('1 दशक पहले', ago={'years': 10}, period='year'),


I have added a few suggestions above to improve the Hindi test cases. Please have a look.

@gutsytechster Done this change, Please Look into it 😊.

I believe these test cases can be added here as well

1 दशक पूर्व

दो दशक पहले

10 दशकों पहले

gutsytechster · 2022-06-16T14:15:20Z

dateparser_data/supplementary_language_data/date_translation_data/hi.yaml

@@ -10,6 +10,8 @@ november:
    - नवम्बर
 december:
    - दिसम्बर
+decade:
+    - दशक


We can add the plural for this as well, e.g. दशकों

@gutsytechster Thanks For Suggestions I'll be Implementing Them ASAP ....

@gutsytechster Done this change, Please Look into it 😊.

Mr-Sunglasses · 2022-06-20T17:27:27Z

@Gallaecio , @gutsytechster Please Look into it I have done all Changes.

.gitignore

Mr-Sunglasses · 2022-06-20T19:16:18Z

@Gallaecio Fixed the changes you requested and also add some improvements 👍🏻

Gallaecio · 2022-06-21T06:23:56Z

.gitignore

@@ -51,4 +51,4 @@ docs/_build
 .vscode/

 # Other
-raw_data
+raw_data


💄 You removed the last empty line 🙂

Gallaecio · 2022-06-21T06:25:54Z

dateparser_data/supplementary_language_data/date_translation_data/en.yaml

@@ -73,7 +73,7 @@ relative-type-regex:
        - (\d+) decades? ago
    in \1 century:
        - in (\d+) centurys?
-        - in (\d+) centur(?:ys?|ies)
+        - in (\d+) centuries?


You can remove the ?. And add "(\\d+) centuries ago" below.

gutsytechster

To confirm that you have added the following support

fortnight support in English
century support in English
decade support in Hindi

gutsytechster · 2022-06-21T07:41:21Z

dateparser/data/date_translation_data/hi.py

+            "(\\d+) दशक मे",
+            "(\\d+) दशकों मे",


Aren't these same as the first two expressions?

gutsytechster · 2022-06-21T07:42:08Z

dateparser/data/date_translation_data/hi.py

-        "बाद"
+        "बाद",
+        "पश्चात",
+        "मे"


This is already present as the first item on this list.

gutsytechster · 2022-06-21T07:44:55Z

dateparser_data/supplementary_language_data/date_translation_data/hi.yaml

@@ -29,7 +32,44 @@ ago:
 in:
    - में
    - बाद
+    - पश्चात
+    - मे


This is repeated as well.

gutsytechster · 2022-06-21T07:45:30Z

dateparser_data/supplementary_language_data/date_translation_data/hi.yaml

+        - (\d+) दशक मे
+        - (\d+) दशकों मे


Repeated as the above two expressions.

gutsytechster · 2022-06-21T07:46:15Z

dateparser_data/supplementary_language_data/date_translation_data/hi.yaml

+        - (\d+) दशक पहले
+        - (\d+) दशकों पहले
+
+


just a nitpick: there is an extra line here.

gutsytechster · 2022-06-21T07:47:03Z

dateparser_data/supplementary_language_data/date_translation_data/hi.yaml

+    - दस: '10'
+    - दश: '10'
+    - ग्यारह: '11'
+    - बारह: '12'


Need to add a new line here.

gutsytechster · 2022-06-21T07:48:57Z

tests/test_freshness_date_parser.py

+        param('1 दशक', ago={'years': 10}, period='year'),
+        param('1 दशक पहले', ago={'years': 10}, period='year'),


I believe these test cases can be added here as well

1 दशक पूर्व

दो दशक पहले

10 दशकों पहले

Mr-Sunglasses added 6 commits September 27, 2021 17:03

added support for decade in hindi

ddff3eb

added support for decade in hindi

96d2e52

added support for fortnignt and century

e826a06

Delete pyvenv.cfg

7185282

Delete hi.py

127149b

Delete hi.yaml

2f1f8fc

fixed accidentally deleted files

7edac70

Mr-Sunglasses changed the title ~~Added suppor for for fortnight and decade~~ Added support for fortnight in century Sep 28, 2021

Mr-Sunglasses changed the title ~~Added support for fortnight in century~~ Added support for fortnight and century Sep 28, 2021

Gallaecio reviewed Sep 28, 2021

View reviewed changes

Mr-Sunglasses added 2 commits September 28, 2021 19:38

added test for centuries

9a585be

added test for centuries

ec50655

Gallaecio approved these changes Sep 29, 2021

View reviewed changes

noviluni requested changes Oct 4, 2021

View reviewed changes

Mr-Sunglasses and others added 2 commits October 4, 2021 21:00

fixed and added centurys support

5b55b2a

Delete pyvenv.cfg

b461617

Gallaecio reviewed Oct 5, 2021

View reviewed changes

Mr-Sunglasses added 2 commits December 6, 2021 00:36

fixed all the bugs now its working fine

ceae086

fixed all bugs , now this is working fine

52582cd

gutsytechster reviewed Jun 16, 2022

View reviewed changes

Mr-Sunglasses added 4 commits June 20, 2022 03:19

Removed repeated test

83c593d

Removed repeated test for last fortnight

e9ab0d0

added my env to gitignore

b97612e

Added plural for decade in hindi

fcab861

Mr-Sunglasses added 10 commits June 20, 2022 03:34

Added plural for decade in hindi

93863fb

Merge branch 'scrapinghub:master' into added-suppor-for-for-fortnight

baec3b6

Removed some garbage files

11c6a5f

Added support for counting from 1 to 12 in Hindi

7649958

Added test for 2 centuries ago in hindi

472cf9b

Add more words for (in) in hindi language

e13c925

Added tests for the in_future in decade in hindi

6f7630c

Added test for decade in future in hindi

d89210c

Added test for coming fortnight

46dcbc9

Added Support for in coming fortnight

10ce3a4

Gallaecio approved these changes Jun 20, 2022

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

Mr-Sunglasses added 3 commits June 21, 2022 00:35

Fixed gitignore

a36c48b

Fixed bug for centuries

2738b28

Added tests for centuries

0943ee1

Merge branch 'scrapinghub:master' into added-suppor-for-for-fortnight

da174a8

Gallaecio reviewed Jun 21, 2022

View reviewed changes

.gitignore

@@ -51,4 +51,4 @@ docs/_build

.vscode/

# Other

raw_data

raw_data

Copy link

Member

Gallaecio Jun 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💄 You removed the last empty line 🙂

Gallaecio reviewed Jun 21, 2022

View reviewed changes

gutsytechster reviewed Jun 21, 2022

View reviewed changes

		param('1 दशक', ago={'years': 10}, period='year'),
		param('1 दशक पहले', ago={'years': 10}, period='year'),

		- (\d+) दशक पहले
		- (\d+) दशकों पहले

Added support for fortnight and century #987

Are you sure you want to change the base?

Added support for fortnight and century #987

Conversation

Mr-Sunglasses commented Sep 27, 2021

Gallaecio commented Sep 28, 2021

Mr-Sunglasses commented Sep 28, 2021

Mr-Sunglasses commented Sep 28, 2021

codecov bot commented Sep 28, 2021 • edited Loading

Codecov Report

Gallaecio left a comment

Choose a reason for hiding this comment

Mr-Sunglasses commented Sep 28, 2021 • edited Loading

Gallaecio left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mr-Sunglasses Oct 5, 2021 • edited Loading

Choose a reason for hiding this comment

Mr-Sunglasses commented Dec 5, 2021

Choose a reason for hiding this comment

Mr-Sunglasses Jun 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mr-Sunglasses Jun 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gutsytechster Jun 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mr-Sunglasses commented Jun 20, 2022

Mr-Sunglasses commented Jun 20, 2022 • edited Loading

Choose a reason for hiding this comment

Gallaecio Jun 21, 2022 • edited Loading

Choose a reason for hiding this comment

gutsytechster left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Sep 28, 2021 •

edited

Loading

Mr-Sunglasses commented Sep 28, 2021 •

edited

Loading

Mr-Sunglasses Oct 5, 2021 •

edited

Loading

Mr-Sunglasses Jun 19, 2022 •

edited

Loading

Mr-Sunglasses Jun 19, 2022 •

edited

Loading

gutsytechster Jun 16, 2022 •

edited

Loading

Mr-Sunglasses commented Jun 20, 2022 •

edited

Loading

Gallaecio Jun 21, 2022 •

edited

Loading